Skip to content
This repository has been archived by the owner on Jan 22, 2022. It is now read-only.

Bottom edge tweaks #435

Open
wants to merge 2 commits into
base: xenial
Choose a base branch
from
Open

Bottom edge tweaks #435

wants to merge 2 commits into from

Conversation

kugiigi
Copy link
Contributor

@kugiigi kugiigi commented Dec 30, 2020

  • Hide navigationbar only when the recent view is fully shown to reduce screen activities/animations when switching to the last tab (short swipe)
  • Enabled immediateRecognition in the bottom edge handler to avoid scrolling webviews when swiping from the bottom
  • Removed the close button from the navigation bar
  • Fixed animation when doing a short swipe for switching to the last tab. Previous animation restarts the position from the bottom of the screen instead of continuing from the swipe/drag. It also previously does not reach the top and jumps at some point.

UniversalSuperBox
UniversalSuperBox suggested changes Feb 4, 2021
View reviewed changes
Copy link
Member

@UniversalSuperBox UniversalSuperBox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like I'm becoming a bit of a broken record at this point... But this PR conflicts on the base branch in NavigationBar.qml. Could you fix that up? I'm not sure which part of the commit should be kept 😅

@kugiigi kugiigi mentioned this pull request Mar 15, 2021
Closed
@UniversalSuperBox
Copy link
Member

This now appears to include changes from #417 and #429. Please edit the branch so it only includes the changes needed to bring back the fullscreen hint, or recreate this PR as appropriate.

@kugiigi kugiigi force-pushed the xenial_-_bottomedge branch from 9f042ef to b9526ae Compare July 15, 2021 14:06
@kugiigi
Copy link
Contributor Author

kugiigi commented Jul 15, 2021

All good now 👍 ...hopefully

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@UniversalSuperBox UniversalSuperBox Awaiting requested review from UniversalSuperBox

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kugiigi @UniversalSuperBox